Re: [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver

[Paolo Bonzini]

Il 19/02/2013 12:31, Dietmar Maurer ha scritto:
> +    start = 0;
> +    end = (bs->total_sectors + BACKUP_BLOCKS_PER_CLUSTER - 1) /
> +        BACKUP_BLOCKS_PER_CLUSTER;
> +
> +    DPRINTF("backup_run start %s %zd %zd\n", bdrv_get_device_name(bs),
> +            start, end);
> +
> +    int ret = 0;
> +
> +    for (; start < end; start++) {
> +        if (block_job_is_cancelled(&job->common)) {
> +            ret = -1;
> +            break;
> +        }
> +

This should call bdrv_is_allocated_above like the other block jobs do.
It would be needed later anyway to backup only the topmost image.

Paolo