[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] Replace all setjmp()/longjmp() with sigsetjm
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] Replace all setjmp()/longjmp() with sigsetjmp()/siglongjmp() |
|
Date: |
Wed, 20 Feb 2013 16:48:34 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
Il 20/02/2013 16:46, Laszlo Ersek ha scritto:
>
>> > +#define sigjmp_buf jmp_buf
>> > +#define sigsetjmp(env, savemask) setjmp(env)
>> > +#define siglongjmp(env, val) longjmp(env, val)
> Apologies for not really reviewing v1; do you think it would be useful
> to add parens around "env" and "val" in the siglongjmp() replacement text?
It is not necessary, I guess we do one way or the other 50% of the time.
> Also, maybe it would be cleaner to replace these windows-oriented
> #defines with a commonly used, new set of macros that would expand to
> sig* and ", 0" on non-windows, and to the current text on windows.
Ugh no. :)
Paolo