qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qemu-ga: fix confusing GAChannelMethod comparis


From: mdroth
Subject: Re: [Qemu-devel] [PATCH] qemu-ga: fix confusing GAChannelMethod comparison
Date: Wed, 20 Feb 2013 10:38:30 -0600
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Feb 19, 2013 at 03:12:34PM +0100, Stefan Hajnoczi wrote:
> In commit 7868e26e5930f49ca942311885776b938dcf3b77
> ("qemu-ga: add initial win32 support") support was added for qemu-ga on
> Windows using virtio-serial.  Other channel methods (ISA serial and UNIX
> domain socket) are not supported on Windows.
> 
> Signed-off-by: Stefan Hajnoczi <address@hidden>

Interesting... I think the original code was actually a bug that just
miraculously worked out thanks to GA_CHANNEL_VIRTIO_SERIAL being 0.

Thanks, applied to qga branch.

> ---
>  qga/channel-win32.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qga/channel-win32.c b/qga/channel-win32.c
> index 16bf44a..7ed98d7 100644
> --- a/qga/channel-win32.c
> +++ b/qga/channel-win32.c
> @@ -287,7 +287,7 @@ GIOStatus ga_channel_write_all(GAChannel *c, const char 
> *buf, size_t size)
>  static gboolean ga_channel_open(GAChannel *c, GAChannelMethod method,
>                                  const gchar *path)
>  {
> -    if (!method == GA_CHANNEL_VIRTIO_SERIAL) {
> +    if (method != GA_CHANNEL_VIRTIO_SERIAL) {
>          g_critical("unsupported communication method");
>          return false;
>      }
> -- 
> 1.8.1.2
> 
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]