Re: [Qemu-devel] [PATCH] tcg: Document tcg_qemu_tb_exec() and provide constants for low bit uses

[Peter Maydell]

On 20 February 2013 18:49, Andreas Färber <address@hidden> wrote:
> Am 20.02.2013 13:20, schrieb Peter Maydell:
> Are you sure it works to separate this comment from the macro by the
> #defines below?

My main use case for doc comments is "read them in situ in the
source code" so that's all I test :-)

>> +#define TB_EXIT_MASK 3
>
>> +#define TB_EXIT_IDX0 0
>> +#define TB_EXIT_IDX1 1
>> +#define TB_EXIT_ICOUNT_EXPIRED 2
>
> This smells like an enum (which would then get its own documentation
> comment some day). IDX0 and IDX1 don't seem to be used, do you have a
> follow-up?

No, they're mostly provided for completeness. (The indexes go in
via tcg_gen_goto_tb() calls mostly, and the TCG spec says the
argument is 0 or 1; they're not mixed in with the other oddities
like expiring icount at that point.)

-- PMM