Re: [Qemu-devel] [PATCH V24 5/7] Add a TPM Passthrough backend driver implementation

[Corey Bryant]

On 02/19/2013 06:30 PM, Stefan Berger wrote:
> On 02/19/2013 05:43 PM, Corey Bryant wrote:
> > > diff --git a/tpm/Makefile.objs b/tpm/Makefile.objs
> > > index 94ad2e7..8abd0f9 100644
> > > --- a/tpm/Makefile.objs
> > > +++ b/tpm/Makefile.objs
> > > @@ -1,4 +1,6 @@
> > > -common-obj-y = tpm.o
> > > +common-obj-y = tpm.o tpm_backend.o
> > >   ifeq ($(CONFIG_TPM),y)
> > >   common-obj-$(CONFIG_TPM_TIS) += tpm_tis.o
> > >   endif
> > > +common-obj-$(CONFIG_TPM_PASSTHROUGH) += tpm_passthrough.o
> > > +
> >
> > Should the ifeq be surrounding more than just tpm_tis?
> Yes, that then also eliminates the stub functions.

Ok yeah because the way it is now I can start a guest with a passthrough 
backend and no frontend.  I assume that any files within this ifeq 
CONFIG_TPM check won't need any corresponding #ifdef CONFIG_TPM checks 
in their source.

--
Regards,
Corey Bryant