qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM co


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration
Date: Thu, 21 Feb 2013 08:46:15 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

Il 21/02/2013 00:34, David Woodhouse ha scritto:
> On Thu, 2013-02-21 at 00:31 +0100, Andreas Färber wrote:
>>
>>
>> Reviewed-by: Andreas Färber <address@hidden>
>>
>> A minor suggestion since you seem to be preparing a v2 would be to do
>> I440FX_PCI_DEVICE(ds), but I don't see dev becoming unused anytime
>> soon, therefore moot.
> 
> Well it's only used because you told me *not* to use d->dev :)
> 
> But OK. The tree at git.infradead.org/users/dwmw2/qemu.git now has that
> change, Laszlo's Reviewed-by: and Tested-by: on all four patches, and
> yours on three of the four. Thanks.

You may go ahead and send a pull request (note that we do send the other
patches together with a pull request, just the cover letter has [PULL
0/4] and the "git request-pull" output).

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]