[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types |
Date: |
Thu, 21 Feb 2013 09:36:33 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
Il 21/02/2013 02:10, Laszlo Ersek ha scritto:
> OTOH if the keyboard reset gets soft in qemu, then OVMF's hard reset
> (the above code) will break. Maybe I could cycle between 0xCF9 and 0x64
> in ResetCold(), starting with 0xCF9.
Yes, that's the right thing to do.
Also, in QEMU you're doing:
if (val & 4) {
qemu_system_reset_request();
return;
}
d->rcr = val & 2; /* keep System Reset type only */
It looks like d->rcr should be set first to match what hardware does
(writing 0x6 causes a cold reset, and that's what you usually find in
the ACPI tables).
Paolo
- Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types, (continued)
- Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types, David Woodhouse, 2013/02/19
- Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types, Anthony Liguori, 2013/02/19
- Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types, David Woodhouse, 2013/02/19
- Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types, Laszlo Ersek, 2013/02/20
- Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types, Paolo Bonzini, 2013/02/20
- Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types, David Woodhouse, 2013/02/20
- Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types, Anthony Liguori, 2013/02/20
- Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types, Laszlo Ersek, 2013/02/20
- Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types, David Woodhouse, 2013/02/20
- Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types, Laszlo Ersek, 2013/02/20
- Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types,
Paolo Bonzini <=
- Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types, David Woodhouse, 2013/02/21
- Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types, Laszlo Ersek, 2013/02/21
- Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types, David Woodhouse, 2013/02/21
- Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types, Anthony Liguori, 2013/02/21
- Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types, David Woodhouse, 2013/02/21
- Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types, Laszlo Ersek, 2013/02/21
- Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types, David Woodhouse, 2013/02/21
- Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types, Paolo Bonzini, 2013/02/21
- Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types, Anthony Liguori, 2013/02/21
- Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types, Laszlo Ersek, 2013/02/21