qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 2/2] qom/object.c: Allow itf cast with num_it


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 2/2] qom/object.c: Allow itf cast with num_itfs = 0
Date: Thu, 21 Feb 2013 07:17:50 -0500 (EST)

> >> diff --git a/qom/object.c b/qom/object.c
> >> index 4b72a64..3d638ff 100644
> >> --- a/qom/object.c
> >> +++ b/qom/object.c
> >> @@ -449,7 +449,8 @@ ObjectClass
> >> *object_class_dynamic_cast(ObjectClass *class,
> >>      TypeImpl *type = class->type;
> >>      ObjectClass *ret = NULL;
> >>
> >> -    if (type->num_interfaces && type_is_ancestor(target_type,
> >> type_interface)) {
> >> +    if (type->class->interfaces &&
> >> +            type_is_ancestor(target_type, type_interface)) {
> >>          int found = 0;
> >>          GSList *i;
> >>
> >>
> >
> > Series looks good, thanks!
>
> Can I take that as an RB or acked-by? :-)

I try to stay as far as possible from QOM these days, but people
don't let me... :)  Yes, it is a Reviewed-by.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]