Re: [Qemu-devel] [PATCH v2] doc: document -netdev hubport

[Markus Armbruster]

Stefan Hajnoczi <address@hidden> writes:

> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  qemu-options.hx | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 4bc9c85..cd18ad1 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1404,7 +1404,8 @@ DEF("netdev", HAS_ARG, QEMU_OPTION_netdev,
>  #ifdef CONFIG_VDE
>      "vde|"
>  #endif
> -    "socket],id=str[,option][,option][,...]\n", QEMU_ARCH_ALL)
> +    "socket|"
> +    "hubport],id=str[,option][,option][,...]\n", QEMU_ARCH_ALL)
>  STEXI
>  @item -net nic[,address@hidden,address@hidden,address@hidden 
> [,address@hidden,address@hidden,address@hidden
>  @findex -net
> @@ -1726,6 +1727,14 @@ vde_switch -F -sock /tmp/myswitch
>  qemu-system-i386 linux.img -net nic -net vde,sock=/tmp/myswitch
>  @end example
>  
> address@hidden -netdev hubport,address@hidden,address@hidden
> +
> +Create a hub port on QEMU "vlan" @var{hubid}.  This syntax is an alternative 
> to
> +the @code{-net @option{vlan}} argument and can be used to connect a NIC
> +specified with @code{-device ...,address@hidden to a QEMU "vlan".

A simpler way to use a "vlan" with -device is "-device e1000,vlan=0".
How is that related to hubport?

> +
> +Note that only NICs can be connected to a hubport, other -netdevs cannot.
> +

Well, netdevs can't be connected to a netdev in general, and hubport is
one.  You can connect up to one device model to a netdev.  I figure you
can additionally connect any number of old-style -net thingies to it,
whether they are NICs or not.  Correct?

>  @item -net dump[,address@hidden,address@hidden,address@hidden
>  Dump network traffic on VLAN @var{n} to file @var{file} 
> (@file{qemu-vlan0.pcap} by default).
>  At most @var{len} bytes (64k by default) per packet are stored. The file 
> format is

I'm afraid you missed netdev_add in hmp-command.hx.