[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/41] qemu-file: temporarily expose qemu_file_s
|
From: |
Juan Quintela |
|
Subject: |
Re: [Qemu-devel] [PATCH 08/41] qemu-file: temporarily expose qemu_file_set_error and qemu_fflush |
|
Date: |
Fri, 22 Feb 2013 11:41:51 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Paolo Bonzini <address@hidden> wrote:
> Right now, migration cannot entirely rely on QEMUFile's automatic
> drop of I/O after an error, because it does its "real" I/O outside
> the put_buffer callback. To fix this until buffering is gone, expose
> qemu_file_set_error which we will use in buffered_flush.
>
> Similarly, buffered_flush is not a complete flush because some data may
> still reside in the QEMUFile's own buffer. This somewhat complicates the
> process of closing the migration thread. Again, when buffering is gone
> buffered_flush will disappear and calling qemu_fflush will not be needed;
> in the meanwhile, we expose the function for use in migration.c.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
- Re: [Qemu-devel] [PATCH 05/41] block-migration: remove useless calls to blk_mig_cleanup, (continued)
- [Qemu-devel] [PATCH 07/41] migration: use qemu_file_set_error to pass error codes back to qemu_savevm_state, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 09/41] migration: flush all data to fd when buffered_flush is called, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 08/41] qemu-file: temporarily expose qemu_file_set_error and qemu_fflush, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 21/41] migration: run setup callbacks out of big lock, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 18/41] block-migration: add lock, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 23/41] Rename buffered_ to migration_, Paolo Bonzini, 2013/02/15