[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] slirp: fixed potential use-after-free of a sock
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH] slirp: fixed potential use-after-free of a socket |
Date: |
Fri, 22 Feb 2013 11:06:34 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2013-02-22 10:57, Vitaly Chipounov wrote:
> Hi,
>
> On 21.02.2013 15:33, Jan Kiszka wrote:
>> On 2013-02-15 12:00, Vitaly Chipounov wrote:
>>> A socket may still have references to it in various queues
>>> at the time it is freed, causing memory corruptions.
>> Did you see it in practice? Or is this patch based on code review? What
>> will happen if those queued mbufs find their ifq_so NULL?
>
> I have a packet trace that triggers this problem when it is injected
> into the guest's NIC.
> I am still not quite sure why this happens, but suspect that it could be
> caused by malformed/partial TCP/IP streams.
OK. Is it shareable?
We need to understand why these bufs still hang around - and exclude
they leak or cause more problems elsewhere.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux