[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 9/9] target-i386: set [+-]feature using static p
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH 9/9] target-i386: set [+-]feature using static properties |
|
Date: |
Fri, 22 Feb 2013 09:42:21 -0300 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Feb 22, 2013 at 07:17:52AM +0100, Igor Mammedov wrote:
[...]
> >
> > Or, maybe we shouldn't even add a "kvmclock" property at all, and
> > translate the legacy "kvmclock" flag to kvmclock1|kvmclock2 inside
> > parse_featurestr()?
> That's what I was proposing a while back. Lets do it this way.
Probably that was at the time when I still wanted to put all
compatibility code inside property getters/setters, but now we are going
to keep most compatibility code inside parse_featurestr(). Also, at that
time I wasn't aware how annoying and complicated it was to define custom
setters/getters for static DeviceClass properties.
--
Eduardo
- [Qemu-devel] [PATCH 7/9] target-i386: cleanup 'foo' feature handling', (continued)
- [Qemu-devel] [PATCH 7/9] target-i386: cleanup 'foo' feature handling', Igor Mammedov, 2013/02/11
- [Qemu-devel] [PATCH 8/9] target-i386: cleanup 'foo=val' feature handling, Igor Mammedov, 2013/02/11
- [Qemu-devel] [PATCH 3/9] target-i386: convert 'hv_spinlocks' to static property, Igor Mammedov, 2013/02/11
- [Qemu-devel] [PATCH 6/9] target-i386: convert 'check' and 'enforce' to static properties, Igor Mammedov, 2013/02/11
- [Qemu-devel] [PATCH 9/9] target-i386: set [+-]feature using static properties, Igor Mammedov, 2013/02/11