Re: [Qemu-devel] [PATCH] gtk: Replace bogus term "VGA" with "display"

[Anthony Liguori]

Jan Kiszka <address@hidden> writes:

> On 2013-02-22 15:17, Anthony Liguori wrote:
>> Jan Kiszka <address@hidden> writes:
>> 
>>> On 2013-02-22 14:21, Anthony Liguori wrote:
>>>> Hi Jan,
>>>>
>>>> Jan Kiszka <address@hidden> writes:
>>>>
>>>>> VGA is a misnomer, only some of our targets have it. Use the more
>>>>> generic term "display" instead.
>>>>>
>>>>> Signed-off-by: Jan Kiszka <address@hidden>
>>>>
>>>> Sorry, I responded to your previous note in my head and forgot to also
>>>> respond on the mailing list.
>>>>
>>>> We expose this "misnomer" a lot.  For instance, qemu -vga cirrus.
>>>
>>> That's because qemu started for x86 only. No excuse to spread this
>>> further in new code.
>>>
>>>>
>>>> OTOH, the term "display" is used to indicate the backend via qemu
>>>> -display sdl.
>>>>
>>>> So calling the VGA tab "Display" after selecting '-display gtk' seems a
>>>> bit confusing to me.
>>>>
>>>> So I'm open to picking better naming but I think we should try to make
>>>> it consistent throughout QEMU.
>>>
>>> We can also call it "screen" or "guest display" - just not VGA,
>>> please.
>> 
>> I don't care what we call it, I'm asking that if you want to change it
>> in one place, change it every where else too.
>
> For obvious reasons, -vga has to stay.

We can introduce a new option that aliases this the -vga option.

[08:50 AM] address@hidden:~/git/qemu$ grep vga *.c | wc -l
51

This is not in the hw/ directory.  All of our internal infrastructure
calls it VGA.  It's odd to me to call it something different in the UI
without changing the internal bits too.

Regards,

Anthony Liguori

> Also, I can leave the code as is.
> My primary point is the user-visible misnomer "VGA". That should be
> fixed before rolling it out. I'll trim down my patch to this.
>
> Jan
>
> -- 
> Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
> Corporate Competence Center Embedded Linux