Re: [Qemu-devel] [PATCH] gtk: Add control menu with stop, reset and power-down entries

[Anthony Liguori]

Jan Kiszka <address@hidden> writes:

> On 2013-02-22 16:38, Jan Kiszka wrote:
>>>> @@ -995,6 +1038,22 @@ static void gd_create_menus(GtkDisplayState *s)
>>>>                                   "<QEMU>/File/Quit");
>>>>      gtk_accel_map_add_entry("<QEMU>/File/Quit", item.keyval, 
>>>> item.modifier);
>>>>  
>>>> +    s->control_menu = gtk_menu_new();
>>>> +    gtk_menu_set_accel_group(GTK_MENU(s->control_menu), accel_group);
>>>> +    s->control_menu_item = gtk_menu_item_new_with_mnemonic(_("_Control"));
>>>> +
>>>> +    s->stop_item = gtk_check_menu_item_new_with_mnemonic(_("_Stop"));
>>>> +    gtk_menu_append(GTK_MENU(s->control_menu), s->stop_item);
>>>
>>> There's a stock menu for this.
>>>
>>> http://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOCK-STOP:CAPS
>> 
>> Ok, v2 follows.
>
> Hmm, I suppose "stock image" and "check" exclude each other, don't they?
> Still, I will pick up the accelerator.

Yeah, but you can pick up the label text which should be automagically
internationalized.

Regards,

Anthony Liguori

>
> Jan
>
> -- 
> Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
> Corporate Competence Center Embedded Linux