Re: [Qemu-devel] [PATCH v3] doc: document -netdev hubport

[Laszlo Ersek]

On 02/22/13 09:49, Stefan Hajnoczi wrote:
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  hmp-commands.hx |  2 +-
>  qemu-options.hx | 11 ++++++++++-
>  2 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 64008a9..c204d31 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1169,7 +1169,7 @@ ETEXI
>      {
>          .name       = "netdev_add",
>          .args_type  = "netdev:O",
> -        .params     = "[user|tap|socket],id=str[,prop=value][,...]",
> +        .params     = "[user|tap|socket|hubport],id=str[,prop=value][,...]",
>          .help       = "add host network device",
>          .mhandler.cmd = hmp_netdev_add,
>      },
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 4bc9c85..cd18ad1 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1404,7 +1404,8 @@ DEF("netdev", HAS_ARG, QEMU_OPTION_netdev,
>  #ifdef CONFIG_VDE
>      "vde|"
>  #endif
> -    "socket],id=str[,option][,option][,...]\n", QEMU_ARCH_ALL)
> +    "socket|"
> +    "hubport],id=str[,option][,option][,...]\n", QEMU_ARCH_ALL)
>  STEXI
>  @item -net nic[,address@hidden,address@hidden,address@hidden 
> [,address@hidden,address@hidden,address@hidden
>  @findex -net
> @@ -1726,6 +1727,14 @@ vde_switch -F -sock /tmp/myswitch
>  qemu-system-i386 linux.img -net nic -net vde,sock=/tmp/myswitch
>  @end example
>  
> address@hidden -netdev hubport,address@hidden,address@hidden
> +
> +Create a hub port on QEMU "vlan" @var{hubid}.  This syntax is an alternative 
> to
> +the @code{-net @option{vlan}} argument and can be used to connect a NIC
> +specified with @code{-device ...,address@hidden to a QEMU "vlan".
> +
> +Note that only NICs can be connected to a hubport, other -netdevs cannot.
> +
>  @item -net dump[,address@hidden,address@hidden,address@hidden
>  Dump network traffic on VLAN @var{n} to file @var{file} 
> (@file{qemu-vlan0.pcap} by default).
>  At most @var{len} bytes (64k by default) per packet are stored. The file 
> format is
> 

Reviewed-by: Laszlo Ersek <address@hidden>