Re: [Qemu-devel] [PATCH] Reenable -Wstrict-prototypes

[Kevin Wolf]

Am 22.02.2013 um 21:33 hat Stefan Weil geschrieben:
> Am 22.02.2013 21:08, schrieb Kevin Wolf:
> > One part of this patch reverts commit 22bc9a46, which disabled the
> > warning. The rest of it deals with the warning by adding a #pragma for
> > newer gcc and by disabling -Werror for compilers that can't deal with
> > the #pragma.
> >
> > Signed-off-by: Kevin Wolf <address@hidden>
> 
> Would you mind using a different solution which needs less changes
> and is more portable?

Even less changes? This patch does already almost nothing, the biggest
change is the comment in configure...

Portability to which compiler is your concern exactly? I can't see what
this would break in practice.

> It's possible to have -Wstrict-prototypes in configure and
> -Wno-strict-prototypes in ui/Makefile (only for ui/gtk.c).

But ideally we'd disable it only for the header, not for ui/gtk.c as a
whole.

Kevin