[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing |
Date: |
Sun, 24 Feb 2013 12:30:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 |
Am 22.02.2013 20:01, schrieb Jens Freimann:
> From: Christian Borntraeger <address@hidden>
>
> This patch fixes a crash when unplugging a virtio-ccw device. We no
> longer need to do that in virtio-ccw since common code does now
> proper handling.
>
> Signed-off-by: Christian Borntraeger <address@hidden>
> Signed-off-by: Jens Freimann <address@hidden>
> ---
> hw/s390x/virtio-ccw.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
> index 231f81e..679afa6 100644
> --- a/hw/s390x/virtio-ccw.c
> +++ b/hw/s390x/virtio-ccw.c
> @@ -865,7 +865,6 @@ static int virtio_ccw_busdev_unplug(DeviceState *dev)
>
> css_generate_sch_crws(sch->cssid, sch->ssid, sch->schid, 1, 0);
>
> - object_unparent(OBJECT(dev));
> qdev_free(dev);
> return 0;
> }
qdev_free() does exactly object_unparent(), so in light of wanting to
get away from qdev I would suggest to rather drop qdev_free() here. Paolo?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 0/3] small virtio-ccw and css patches, Jens Freimann, 2013/02/22
- [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing, Jens Freimann, 2013/02/22
- Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing,
Andreas Färber <=
- Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing, Christian Borntraeger, 2013/02/24
- Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing, Paolo Bonzini, 2013/02/25
- Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing, Christian Borntraeger, 2013/02/25
- Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing, Paolo Bonzini, 2013/02/25
- Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing, Christian Borntraeger, 2013/02/25
- Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing, Andreas Färber, 2013/02/25
[Qemu-devel] [PATCH 3/3] s390/virtio-ccw: remove redundant call to blockdev_mark_auto_del, Jens Freimann, 2013/02/22
[Qemu-devel] [PATCH 2/3] s390/css: Fix subchannel detection, Jens Freimann, 2013/02/22