Re: [Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros

[Andreas Färber]

Am 24.02.2013 12:31, schrieb Peter Maydell:
> On 24 February 2013 11:27, Andreas Färber <address@hidden> wrote:
>> Am 22.02.2013 19:22, schrieb Peter Maydell:
>>> Yeah, I deliberately dropped a bunch of what I felt were
>>> extraneous blank lines :-)
>>
>> I've applied it to qom-cpu since it conflicts with my additions of
>> vmstate_..._cpu fields and ..._do_interrupt() functions.
>>
>> https://github.com/afaerber/qemu-cpu/commits/qom-cpu
>>
>> But I will remind you of you messing with my coding style next time you
>> ask me to redo any ifs to your liking. May Markus be my witness. Either
>> we respect each other's style in cross-target refactorings or we don't.
> 
> In this case I actually kind of 50% thought they were the
> result of conflicts/merge process rather than intentional,
> which is why I cleaned them up. I don't actually care one
> way or the other, so you can reinstate them if you prefer.

My reasoning was to differenciate between the header guard and any
in-file #ifdef CONFIG_USER_ONLY or TARGET_FOO, which for functions I
usually separate by one line.

I don't really care too much though, it's just the principle that angers
me that you made me go through hoops, propagating
adopt-the-author's-style when it comes to target-arm files, while now
violating your own paradigm and apparently even finding that funny.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg