Re: [Qemu-devel] [PATCH v6 7/9] hw/kvm/arm_gic: Implement support for KVM in-kernel ARM GIC

[Peter Maydell]

On 23 February 2013 15:29, Andreas Färber <address@hidden> wrote:
>> +static int kvm_arm_gic_init(SysBusDevice *dev)
>
> Please make this a realize function ...

Will do. As you've probably guessed, this was written some time
ago and I never updated it to match our current recommendations.

>> +    KVMARMGICClass *kgc = KVM_ARM_GIC_GET_CLASS(s);
>> +
>> +    kgc->parent_init(dev);
>
> ... and call sbc->init(dev) here as long as the base class is not updated.

Maybe I should just update the base class?

>> +static void kvm_arm_gic_class_init(ObjectClass *klass, void *data)
>> +{
>> +    DeviceClass *dc = DEVICE_CLASS(klass);
>> +    SysBusDeviceClass *sbc = SYS_BUS_DEVICE_CLASS(klass);
>> +    ARMGICCommonClass *agcc = ARM_GIC_COMMON_CLASS(klass);
>> +    KVMARMGICClass *kgc = KVM_ARM_GIC_CLASS(klass);
>
> Please separate variable definitions and rest of block by a white line,
> here and elsewhere.

OK.

-- PMM