[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing |
Date: |
Mon, 25 Feb 2013 02:55:40 -0500 (EST) |
> Another thing is, that qdev_free looks now different, some days ago
> it also did an unref. As far as I can see the object_unparent in
> virtio-ccw was always the wrong thing to do.
object_unparent is "almost" idempotent, i.e. idempotent as long as it does
not cause the last reference to go away. So, doing an object_unparent
before qdev_free was not wrong when qdev_free did an object_unref.
I think qdev_free is better, unless we want to change all of them
at the same time.
Paolo
> So for a potential backport
> this version of the patch might be better.
> Paolo, do you have any guidance?
>
> Christian
>
>
[Qemu-devel] [PATCH 3/3] s390/virtio-ccw: remove redundant call to blockdev_mark_auto_del, Jens Freimann, 2013/02/22
[Qemu-devel] [PATCH 2/3] s390/css: Fix subchannel detection, Jens Freimann, 2013/02/22