Re: [Qemu-devel] [PATCHv3] tap: set IFF_ONE_QUEUE per default

[Stefan Hajnoczi]

On Mon, Feb 25, 2013 at 10:17:08AM +0100, Peter Lieven wrote:

git-am(1) cannot apply this patch.  There is whitespace damage,
untouched lines have an extra space.  I applied it manually, please use
git-send-email(1) or fix your email client configuration for future
patches.

> historically the kernel queues packets two times. once
> at the device and second in qdisc. this is believed to cause
> interface stalls if one of these queues overruns.
> 
> setting IFF_ONE_QUEUE is the default in kernels >= 3.8. the
> flag is ignored since then. see kernel commit
> 5d097109257c03a71845729f8db6b5770c4bbedc
> 
> v3:
>  - probe if IFF_ONE_QUEUE feature is available
> 
> v2:
>  - do only set the flag on linux as it breaks macvtap
>  - define IFF_ONE_QUEUE in tap-linux.h

In the future, please put patch revision below the '---' in the future
so it's not part of the commit description.  That way it is not stored
in git (the information isn't useful once the patch has been merged).

> Signed-off-by: Peter Lieven <address@hidden>
> ---
>  net/tap-linux.c |   10 ++++++----
>  net/tap-linux.h |    9 +++++----
>  2 files changed, 11 insertions(+), 8 deletions(-)

Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net

Stefan