[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 6/8] petalogix_ml605_mmu: Attach ethernet to
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v2 6/8] petalogix_ml605_mmu: Attach ethernet to machine |
Date: |
Mon, 25 Feb 2013 13:53:59 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 |
Am 25.02.2013 09:50, schrieb Peter Crosthwaite:
> Explicitily make the ethernet a child of the machine. This is needed to set
> and use links pre-realize. Also makes the ethernet initialization consistent
> with its peer DMA.
>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
>
> hw/petalogix_ml605_mmu.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/hw/petalogix_ml605_mmu.c b/hw/petalogix_ml605_mmu.c
> index 98e647d..e3528c0 100644
> --- a/hw/petalogix_ml605_mmu.c
> +++ b/hw/petalogix_ml605_mmu.c
> @@ -134,6 +134,8 @@ petalogix_ml605_init(QEMUMachineInitArgs *args)
> dma = qdev_create(NULL, "xlnx.axi-dma");
>
> /* FIXME: attach to the sysbus instead */
> + object_property_add_child(qdev_get_machine(), "xilinx-eth", OBJECT(eth0),
> + NULL);
> object_property_add_child(qdev_get_machine(), "xilinx-dma", OBJECT(dma),
> NULL);
>
Reviewed-by: Andreas Färber <address@hidden>
BTW concerning the above FIXME, I believe we do have a /machine/sysbus
node or so, which contains link<> properties to its child devices.
Adding those devices as child<> properties before qdev_init*() (realized
= true) changes the canonical paths these are displayed as from
/machine/unassigned/device[n] or no to /machine/xilinx-eth in this case.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH v2 1/8] xilinx_axienet: typedef XilinxAXIEnet struct, (continued)
- [Qemu-devel] [PATCH v2 2/8] xilinx_axienet: Defined and use type cast macro, Peter Crosthwaite, 2013/02/25
- [Qemu-devel] [PATCH v2 3/8] xilinx_axienet: Register reset properly, Peter Crosthwaite, 2013/02/25
- [Qemu-devel] [PATCH v2 4/8] xilinx_axienet: converted init->realize, Peter Crosthwaite, 2013/02/25
- [Qemu-devel] [PATCH v2 5/8] petalogix_ml605_mmu: Fix machine node attachment, Peter Crosthwaite, 2013/02/25
- [Qemu-devel] [PATCH v2 6/8] petalogix_ml605_mmu: Attach ethernet to machine, Peter Crosthwaite, 2013/02/25
- Re: [Qemu-devel] [PATCH v2 6/8] petalogix_ml605_mmu: Attach ethernet to machine,
Andreas Färber <=
- [Qemu-devel] [PATCH v2 8/8] xilinx_axienet: stub out second stream connection, Peter Crosthwaite, 2013/02/25
- [Qemu-devel] [PATCH v2 7/8] xilinx_axienet: Create Proxy object for stream, Peter Crosthwaite, 2013/02/25