Re: [Qemu-devel] [libvirt] [PATCH] vl.c: Support multiple CPU ranges on -numa option

[Eric Blake]

On 02/21/2013 01:57 PM, Eduardo Habkost wrote:

>>> Note that the following format, currently used by libvirt:
>>>
>>>   -numa nodes,cpus=A,B,C,D
>>>
>>> will _not_ work yet, as "," is the option separator for the command-line
>>> option parser, and it will require changing the -numa option parsing
>>> code to handle "cpus" as a special case.
>>
>> No way.
> 
> Agreed.  :-)
> 
> The bad news is that libvirt uses this format since forever, this format
> never worked, and nobody ever noticed that this was broken.

Well, libvirt just entered freeze for 1.0.3.  I think the best course of
action on libvirt's side is to patch 1.0.3 to flat-out reject any cpumap
that cannot be represented in a syntax understood by qemu 1.4; then a
future libvirt can re-add support for whatever new syntax qemu 1.5 deems
as appropriate.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature