Re: [Qemu-devel] [PATCH V6 14/14] hmp: show snapshots on single block device

[Wenchao Xia]

于 2013-2-20 4:51, Eric Blake 写道:
> On 02/18/2013 07:09 AM, Wenchao Xia wrote:
> >    This patch added the support of showing internal snapshots on a
> > single block device in hmp layer, by simply change parameter in
>
> s/change/changing a/
>
> > calling of qmp funtion.
>
> s/funtion/function/
  OK.

> > Signed-off-by: Wenchao Xia <address@hidden>
> > ---
> >   hmp.c     |    7 ++++++-
> >   monitor.c |    6 +++---
> >   2 files changed, 9 insertions(+), 4 deletions(-)
> >
> > diff --git a/hmp.c b/hmp.c
> > index d29787f..834ee42 100644
> > --- a/hmp.c
> > +++ b/hmp.c
> > @@ -633,8 +633,10 @@ void hmp_info_snapshots(Monitor *mon, const QDict *qdict)
> >   {
> >       Error *err = NULL;
> >       SnapshotInfoList *list;
> > +    const char *device = qdict_get_try_str(qdict, "device");
> > +    bool has_device = device ? true : false;
>
> The prevailing style appears to be:
>
> bool has_device = !!device;
  oops, thanks for tipping it.


--
Best Regards

Wenchao Xia