qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 2/6] add basic backup support to block driver


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v4 2/6] add basic backup support to block driver
Date: Wed, 27 Feb 2013 14:26:57 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Feb 26, 2013 at 05:02:19PM +0000, Dietmar Maurer wrote:
> > If you want to implement an alternative to rate-limiting, please do it in a
> > separate patch series and make it work for all block job types.
> 
> Well, I hoped you can see how to fix that. I guess the same applies for other 
> types of block
> jobs, and I simply found no other solution.
> 
> Adding and IO queue and implement a scheduler is likely not what we want to 
> do. 

The starting point for something smarter than just no policy or
rate-limiting is BlockDriverState->tracked_requests.  block.c keeps
track of active requests using this list.

The simplest policy using bs->tracked_requests is to only submit block
job I/O requests when the list is empty.

Want to try this approach?  (The drawback is that the guest can starve
the block job by submitting I/O all the time.)

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]