[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa o
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option |
Date: |
Wed, 27 Feb 2013 16:57:15 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
Il 27/02/2013 16:42, Anthony Liguori ha scritto:
> There's such thing as list support in QemuOpts. The only way
> QemuOptsVisitor was able to implement it was to expose QemuOpts publicly
> via options_int.h and rely on a implementation detail.
>
> There are fixed types supported by QemuOpts. It just so happens that
> whenever qemu_opt_set() is called, instead of replacing the last
> instance, the value is either prepended or appended in order to
> implement a replace or set-if-unset behavior.
Fair enough. Nobody said the implementation is pretty.
> If we want to have list syntax, we need to introduce first class support
> for it. Here's a simple example of how to do this.
If it is meant as a prototype only, and the final command-line syntax
would be with repeated keys, that's okay. I think that Eduardo/Markus/I
are focusing on the user interface, you're focusing in the implementation.
In the meanwhile, however, it seems to me that Eduardo can use
QemuOptsVisitor---which can also hide the details and provide type safety.
Paolo
- [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option, Eduardo Habkost, 2013/02/21
- Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option, Markus Armbruster, 2013/02/26
- Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option, Eduardo Habkost, 2013/02/26
- Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option, Anthony Liguori, 2013/02/26
- Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option, Eduardo Habkost, 2013/02/26
- Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option, Paolo Bonzini, 2013/02/26
- Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option, Markus Armbruster, 2013/02/26
- Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option, Anthony Liguori, 2013/02/27
- Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option, Eduardo Habkost, 2013/02/27
- Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option, Paolo Bonzini, 2013/02/27
- Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option, Eduardo Habkost, 2013/02/27
- Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option, Markus Armbruster, 2013/02/28
- Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option, Anthony Liguori, 2013/02/27
- Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option, Eduardo Habkost, 2013/02/27
- Re: [Qemu-devel] [libvirt] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option, Eric Blake, 2013/02/27
- Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option, Anthony Liguori, 2013/02/27
- Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option, Markus Armbruster, 2013/02/28
- Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option, Anthony Liguori, 2013/02/28