[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V7 09/14] block: move bdrv_snapshot_find() to bl
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH V7 09/14] block: move bdrv_snapshot_find() to block.c |
|
Date: |
Wed, 27 Feb 2013 17:22:29 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 27.02.2013 um 17:04 hat Markus Armbruster geschrieben:
> Wenchao Xia <address@hidden> writes:
>
> > Signed-off-by: Wenchao Xia <address@hidden>
> > Reviewed-by: Eric Blake <address@hidden>
> > ---
> > block.c | 24 ++++++++++++++++++++++++
> > include/block/block.h | 2 ++
> > savevm.c | 22 ----------------------
> > 3 files changed, 26 insertions(+), 22 deletions(-)
>
> Perhaps savevm.c isn't the best home for snapshot stuff, but I don't
> like it in block.c any better. block.c is already unwieldy, and I'd
> like us to try limiting it to core block stuff.
>
> Kevin, Stefan, any ideas?
Take some more snapshot related functions from block.c and move them to
block/snapshot.c?
Kevin
[Qemu-devel] [PATCH V7 12/14] hmp: add function hmp_info_snapshots(), Wenchao Xia, 2013/02/26
[Qemu-devel] [PATCH V7 13/14] hmp: switch snapshot info function to qmp based one, Wenchao Xia, 2013/02/26
[Qemu-devel] [PATCH V7 10/14] block: distinguish id and name in bdrv_find_snapshot(), Wenchao Xia, 2013/02/26
[Qemu-devel] [PATCH V7 11/14] qmp: add interface query-snapshots, Wenchao Xia, 2013/02/26