Re: [Qemu-devel] [PATCH 2/3] asn1 ber visitors

[Paolo Bonzini]

Il 27/02/2013 21:03, Joel Schopp ha scritto:
> 
>>> +ber-nested-y = ber-input-visitor.o ber-output-visitor.o ber-common.o
>>> +ber-obj-y = $(addprefix ber/, $(ber-nested-y))
>>> +
>>> +common-obj-y += qemu-char.o qemu-file.o $(ber-obj-y) #aio.o
>>
>> I don't see any justification for that statement? You should be able to
>> add whatever file you like on a separate Makefile line without problems.
>>
>> Also I believe you are breaking dependency handling by not just doing
>> common-obj-y += ber/
>> utilising our existing object file unnesting rules.
> 
> That's what I thought as well, but it didn't compile.  This does.

Then please ask for help.  Do not work around what you didn't understand
(it's not your fault, it's complex stuff).

Paolo