Re: [Qemu-devel] [PATCH 01/11] NVMe: Initial commit for NVM Express device

[Markus Armbruster]

Keith Busch <address@hidden> writes:

> On Wed, 27 Feb 2013, Paolo Bonzini wrote:
>> Il 27/02/2013 10:30, Andreas Färber ha scritto:
[...]
>> Finally, and unrelated to the code above, we usually do not add new "if"
>> values.  It's enough to have access via if=none & -device.  In any case
>> it should be a separate patch, so it's easy to drop it if that's the
>> decision.
>
> I can make a separate patch for this, no problem. The only reason I
> added a new "if" was for hot add, as I don't see a way to do a storage
> pci_add without a new "if".

pci_add is obsolescent in HMP, and unavailable in QMP.  Use device_add
instead.  Works like this:

(qemu) device_add lsi,id=scsi.0
(qemu) drive_add "" if=none,id=scsicd0,media=cdrom
OK
(qemu) device_add scsi-cd,id=scsi5,scsi-id=5,drive=scsicd0