|
From: | Wenchao Xia |
Subject: | Re: [Qemu-devel] [PATCH V7 09/14] block: move bdrv_snapshot_find() to block.c |
Date: | Fri, 01 Mar 2013 09:51:53 +0800 |
User-agent: | Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 |
δΊ 2013-2-28 0:22, Kevin Wolf ει:
Am 27.02.2013 um 17:04 hat Markus Armbruster geschrieben:Wenchao Xia <address@hidden> writes:Signed-off-by: Wenchao Xia <address@hidden> Reviewed-by: Eric Blake <address@hidden> --- block.c | 24 ++++++++++++++++++++++++ include/block/block.h | 2 ++ savevm.c | 22 ---------------------- 3 files changed, 26 insertions(+), 22 deletions(-)Perhaps savevm.c isn't the best home for snapshot stuff, but I don't like it in block.c any better. block.c is already unwieldy, and I'd like us to try limiting it to core block stuff. Kevin, Stefan, any ideas?Take some more snapshot related functions from block.c and move them to block/snapshot.c? Kevin
Hi, Stefan Do you also agree about adding new file block/snapshot.c? -- Best Regards Wenchao Xia
[Prev in Thread] | Current Thread | [Next in Thread] |