Re: [Qemu-devel] [PATCH] check-qjson: More thorough testing of UTF-8 in strings

[Markus Armbruster]

Blue Swirl <address@hidden> writes:

> On Thu, Feb 28, 2013 at 7:42 PM, Markus Armbruster <address@hidden> wrote:
>> Blue Swirl <address@hidden> writes:
>>
>>> On Thu, Feb 28, 2013 at 8:14 AM, Markus Armbruster <address@hidden> wrote:
[...]
>>>> Looks like the JSON formatter is not just broken (we knew that already),
>>>> it's broken in machine-dependent ways.  Good to know, thanks for
>>>> reporting.
>>>>
>>>> Obvious ways to get "make check" pass for you again *now*:
>>>>
>>>> * Disable check-qjson.  That's too big a hammer for me.
>>>>
>>>> * Disable test case 2.1.4 with a comment explaining why.
>>>>
>>>> * Suitable #ifdeffery around the expected value.
>>>>
>>>> Preferences?
>>>
>>> * Fix JSON formatter :-)
>>
>> I want that too, but I'm afraid we can't have it *now* :)
>>
>>> Disabling 2.1.4 only reveals the next problem:
>>> GTESTER tests/check-qjson
>>> GTester: last random seed: R02S6754f3523201dc81bb21de42e2ba843c
>>> **
>>> ERROR:/src/qemu/tests/check-qjson.c:777:utf8_string: assertion failed
>>> (qstring_get_str(str) == json_out): ("\"\\u8200\200\200\"" ==
>>> "\"\\u8200\\uFFFF\\uFFFF\"")
>>
>> All right, I give up.  I can't fix to_json() tonight (I have maybe 30
>> minutes of usable brain left), but I can make it portably wrong.  Please
>> try the appended patch.
>
> GTESTER tests/check-qjson
> GTester: last random seed: R02Scc9b8a0a880770aaee720c8f98cc953d
> **
> ERROR:/src/qemu/tests/check-qjson.c:775:utf8_string: assertion failed
> (qstring_get_str(str) == json_out): ("\"\\u0400\200\"" ==
> "\"\\u0400\\uFFFF\"")

Working on a real fix, please be patient.