[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command |
|
Date: |
Fri, 01 Mar 2013 10:50:03 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 |
On 03/01/2013 10:38 AM, Eric Blake wrote:
>> + error_setg_errno(errp, errno, "Invalid time %ld for overflow",
>> + time_ns);
>
> That wording sounds awkward. Worse, errno is NOT set to anything sane,
> so you do NOT want error_setg_errno. And %ld is wrong for int64_t on
> 32-bit platforms. How about:
>
> error_setg(errp, "Time %" PRI64D " is too large", time_ns);
Don't know what I was thinking; there is no PRI64D. I meant PRId64.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature