[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] pci_host: Drop write-only address_space field
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH] pci_host: Drop write-only address_space field |
|
Date: |
Fri, 01 Mar 2013 19:57:54 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 |
Am 01.03.2013 19:50, schrieb Peter Maydell:
> On 1 March 2013 18:33, Andreas Färber <address@hidden> wrote:
>> Am 01.03.2013 17:57, schrieb Peter Maydell:
>>> The address_space field of PCIHostState was only ever written, never used.
>>> Drop it completely.
>>>
>>> Signed-off-by: Peter Maydell <address@hidden>
>>
>> Reviewed-by: Andreas Färber <address@hidden>
>
> Incidentally I suspect you could if you liked get rid of all
> the uses of PCIHostState in prep.c (and the #include of pci_host.h),
> since it's now only using &pcihost->busdev as an opaque way of
> saying SYS_BUS_DEVICE(dev)).
I believe I do have PCI_DEVICE() and ISA_BUS() changes in my tree. :)
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg