[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and help
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions |
Date: |
Mon, 04 Mar 2013 08:28:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130216 Thunderbird/17.0.3 |
Hi,
>> For maximum flexibility, a callback could be specified but then we
>> overlap memory API.
>
> I think this is a good idea, but continuing on the theme of what this
> API is trying to achieve I think there should be capability for
> per-bit function definitions. On the topic I think Gerd has played
> with the idea of per-register callbacks for some device models in the
> past.
hw/intel-hda.c is it.
Predates memory api though and thus doesn't integrated with it, although
it makes sense of course. Could be as simple as a generic MemoryRegionOps.
I'm not sure it is that useful to have per-bit callbacks. For "normal"
devices you rarely need that, and for gpio arrays probably want more
than just callbacks per bit (qemu_irqs for example).
cheers,
Gerd
- [Qemu-devel] [RFC PATCH v1 0/4] Data Driven device registers & Zynq DEVCFG, Peter Crosthwaite, 2013/03/03
- [Qemu-devel] [RFC PATCH v1 1/4] qemu-log: Allow checking of the current mask, Peter Crosthwaite, 2013/03/03
- [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions, Peter Crosthwaite, 2013/03/03
- Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions, Blue Swirl, 2013/03/03
- Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions, Michael S. Tsirkin, 2013/03/04
- Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions, Blue Swirl, 2013/03/04
- Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions, Michael S. Tsirkin, 2013/03/05
- Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions, Gerd Hoffmann, 2013/03/05
- Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions, Michael S. Tsirkin, 2013/03/05
- Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions, Peter Crosthwaite, 2013/03/06
- Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions, Peter Maydell, 2013/03/06
- Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions, Blue Swirl, 2013/03/09
Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions, Gerd Hoffmann, 2013/03/04