Re: [Qemu-devel] [PATCH 3/4] target-arm: Fix VFP register byte order in GDB remote

[Fabien Chouteau]

On 03/01/2013 09:51 PM, Paul Brook wrote:
>> From GDB Remote Serial Protocol doc:
>>
>> "The bytes with the register are transmitted in target byte order."
> 
>>          /* Aliases for Q regs.  */
>>          nregs += 16;
>>          if (reg < nregs) {
>>
>> -            stfq_le_p(buf, env->vfp.regs[(reg - 32) * 2]);
>> -            stfq_le_p(buf + 8, env->vfp.regs[(reg - 32) * 2 + 1]);
>> +            stfq_p(buf, env->vfp.regs[(reg - 32) * 2]);
>> +            stfq_p(buf + 8, env->vfp.regs[(reg - 32) * 2 + 1]);
> 
> This is wrong. You're still using little-endian ordering of words.
> 

Can you explain a little bit further? If I'm in big-endian mode, stfq_p() will 
be stfq_be_p(), right?

Thanks,

-- 
Fabien Chouteau