[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v13 2/8] start vm after resetting it
|
From: |
Hu Tao |
|
Subject: |
Re: [Qemu-devel] [PATCH v13 2/8] start vm after resetting it |
|
Date: |
Tue, 5 Mar 2013 11:06:23 +0800 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Mar 04, 2013 at 10:32:17AM +0100, Paolo Bonzini wrote:
> Il 28/02/2013 13:13, Hu Tao ha scritto:
> > From: Wen Congyang <address@hidden>
> >
> > The guest should run after resetting it, but it does not run if its
> > old state is RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED.
> >
> > We don't set runstate to RUN_STATE_PAUSED when resetting the guest,
> > so the runstate will be changed from RUN_STATE_INTERNAL_ERROR or
> > RUN_STATE_PAUSED to RUN_STATE_RUNNING(not RUN_STATE_PAUSED).
>
> This is also debatable. In particular, restarting an INTERNAL_ERROR
> guest makes it harder to inspect the state at the time of the failure.
>
> INTERNAL_ERROR should never happen, let's separate this patch too.
Sure.
>
> Paolo