Re: [Qemu-devel] [PATCH V7 09/14] block: move bdrv_snapshot_find() to block.c

[Wenchao Xia]

于 2013-3-4 21:02, Stefan Hajnoczi 写道:
> On Fri, Mar 01, 2013 at 09:51:53AM +0800, Wenchao Xia wrote: > 于 2013-2-28 
> 0:22, Kevin Wolf 写道:
> > > Am 27.02.2013 um 17:04 hat Markus Armbruster geschrieben:
> > > > Wenchao Xia <address@hidden> writes:
> > > >
> > > > > Signed-off-by: Wenchao Xia <address@hidden>
> > > > > Reviewed-by: Eric Blake <address@hidden>
> > > > > ---
> > > > >   block.c               |   24 ++++++++++++++++++++++++
> > > > >   include/block/block.h |    2 ++
> > > > >   savevm.c              |   22 ----------------------
> > > > >   3 files changed, 26 insertions(+), 22 deletions(-)
> > > >
> > > > Perhaps savevm.c isn't the best home for snapshot stuff, but I don't
> > > > like it in block.c any better.  block.c is already unwieldy, and I'd
> > > > like us to try limiting it to core block stuff.
> > > >
> > > > Kevin, Stefan, any ideas?
> > >
> > > Take some more snapshot related functions from block.c and move them to
> > > block/snapshot.c?
> > >
> > > Kevin
> > Hi, Stefan
> >    Do you also agree about adding new file block/snapshot.c?
>
> Yes, I agree.
>
> Stefan
great. Also there are some other functions such as image info
collecting, do you think new file block/misc.c is suitable
to store those functions there?

--
Best Regards

Wenchao Xia