[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V7 09/14] block: move bdrv_snapshot_find() to bl
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH V7 09/14] block: move bdrv_snapshot_find() to block.c |
Date: |
Tue, 05 Mar 2013 11:52:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
Il 05/03/2013 11:08, Kevin Wolf ha scritto:
>> >
>> > As discussed on IRC, it's fine by me. If a better way to organize these
>> > functions becomes clear in the future they can be moved.
> As also discussed on IRC, I'm not excited by having a block/misc.c. We
> already have something for "everything block related that doesn't fit
> elsewhere" and it's block.c. I couldn't tell if a function belong into
> block.c or block/misc.c.
>
> I suggested having a file that concentrates all function related to
> QAPI, the monitor and JSON (including the qemu-img JSON output) and call
> it something like block/qapi.c (I'm open for better suggestions). This
> would at least make it clear if a function should be in there or not.
I agree with Kevin.
Paolo