Re: [Qemu-devel] [PATCH 12/12] ARM: Add arm64 target to configure

[Peter Maydell]

On 6 March 2013 10:01, Alexander Graf <address@hidden> wrote:
> If we want to compile a target machine type that is AArch64 capable,
> we need to add a new 64-bit capable ARM target. To make things easily
> understandable, I call this arm64.

We may have to have a naming argument later but I want to think
my position through first :-)

> --- a/configure
> +++ b/configure
> @@ -3987,6 +3987,15 @@ case "$target_arch2" in
>      target_llong_alignment=4
>      target_libs_softmmu="$fdt_libs"
>    ;;
> +  arm64)
> +    TARGET_BASE_ARCH=arm
> +    TARGET_ABI_DIR=arm

Hmm. Shouldn't the ABI dir be different? After all, the ABI is...

> +    bflt="yes"

Really?

> diff --git a/linux-user/Makefile.objs b/linux-user/Makefile.objs
> index 5899d72..7a2cb94 100644
> --- a/linux-user/Makefile.objs
> +++ b/linux-user/Makefile.objs
> @@ -4,4 +4,5 @@ obj-y = main.o syscall.o strace.o mmap.o signal.o \
>  obj-$(TARGET_HAS_BFLT) += flatload.o
>  obj-$(TARGET_I386) += vm86.o
>  obj-$(TARGET_ARM) += arm/nwfpe/
> +obj-$(TARGET_ARM64) += arm/nwfpe/

I really don't want to drag the nwfpe FPA emulation code into
AArch64. It's pretty nearly obsolete for 32 bit ARM and it
definitely makes zero sense for 64 bit binaries.

-- PMM