[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] qga: implement qmp_guest_set_vcpus() for Li
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] qga: implement qmp_guest_set_vcpus() for Linux with sysfs |
|
Date: |
Wed, 6 Mar 2013 04:57:19 -0500 (EST) |
> On 03/06/13 00:37, Eric Blake wrote:
>
> > I guess I had in my mind %c instead of %u; still, I can't help but
> > wonder if fprintf() and buffering is overkill, compared to just
> > doing
> > something like this:
> > write(fd, &"01"[vcpu->online], 1);
> >
> > (okay, I hope you would favor readability over my compact
> > representation, but you get the point).
>
> I'd be crucified on qemu-devel if I tried to pull off something like
> the above :)
I think stdio is just fine...
Paolo
[Qemu-devel] [PATCH 1/3] qga: introduce guest-get-vcpus / guest-set-vcpus with stubs, Laszlo Ersek, 2013/03/04
[Qemu-devel] [PATCH 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs, Laszlo Ersek, 2013/03/04