Re: [Qemu-devel] [PATCH v6 12/24] hw/nand.c: bug fix to erase operation

[Peter Crosthwaite]

Hi Kuo Jung, Peter,

This fixes a no-boot bug in u-boot for us as well. RE PMMs comments in
v5, I realise the desire to fix this properly by rewriting that
if-else mess, but can we get a merge on this one more immediately to
get QEMU working again? Rewriting this is probably not at the top of
either mine or Kuo Jungs priority list but at the same time we would
like a working boot.

Regards,
Peter

On Wed, Mar 6, 2013 at 5:27 PM, Kuo-Jung Su <address@hidden> wrote:
> The s->addr should be reset along with the s->addrlen,
> or it might have the previous address shifted to MSB
> and then causes problem to nand erase operation.
>
> Signed-off-by: Kuo-Jung Su <address@hidden>

Acked-by: Peter Crosthwaite <address@hidden>

> ---
>  hw/nand.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/nand.c b/hw/nand.c
> index 61e918f..6b2f2b8 100644
> --- a/hw/nand.c
> +++ b/hw/nand.c
> @@ -511,6 +511,7 @@ void nand_setio(DeviceState *dev, uint32_t value)
>              nand_command(s);
>
>          if (s->cmd != NAND_CMD_RANDOMREAD2) {
> +            s->addr = 0;
>              s->addrlen = 0;
>          }
>      }
> --
> 1.7.9.5
>
>