[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] threadpool: drop global thread pool
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 5/5] threadpool: drop global thread pool |
Date: |
Thu, 7 Mar 2013 11:07:42 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Mar 06, 2013 at 05:35:09PM +0100, Paolo Bonzini wrote:
> Il 06/03/2013 16:45, Stefan Hajnoczi ha scritto:
> > Now that each AioContext has a ThreadPool and the main loop AioContext
> > can be fetched with qemu_get_aio_context(), we can eliminate the concept
> > of a global thread pool from thread-pool.c.
> >
> > The submit functions must take a ThreadPool* argument.
>
> This is certainly ok for thread-pool.c. For raw-posix and raw-win32,
> what about adding already a bdrv_get_aio_context() function and using
> that in paio_submit? Is it putting the cart before the horse?
Thanks, we might as well do that. Then I won't have to go back and
modify block/raw-posix.c and block/raw-win32.c in the next patch series
which lets BlockDriverState bind to an AioContext.
Stefan
- [Qemu-devel] [PATCH 0/5] threadpool: support multiple ThreadPools, Stefan Hajnoczi, 2013/03/06
- [Qemu-devel] [PATCH 3/5] aio: add a ThreadPool instance to AioContext, Stefan Hajnoczi, 2013/03/06
- [Qemu-devel] [PATCH 1/5] threadpool: move globals into struct ThreadPool, Stefan Hajnoczi, 2013/03/06
- [Qemu-devel] [PATCH 4/5] main-loop: add qemu_get_aio_context(), Stefan Hajnoczi, 2013/03/06
- [Qemu-devel] [PATCH 5/5] threadpool: drop global thread pool, Stefan Hajnoczi, 2013/03/06
- [Qemu-devel] [PATCH 2/5] threadpool: add thread_pool_new() and thread_pool_free(), Stefan Hajnoczi, 2013/03/06