[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 6/7] linux-user: Support setgroups syscall with no g
From: |
riku . voipio |
Subject: |
[Qemu-devel] [PATCH 6/7] linux-user: Support setgroups syscall with no groups |
Date: |
Thu, 7 Mar 2013 10:21:31 +0000 |
From: Dillon Amburgey <address@hidden>
Signed-off-by: Dillon Amburgey <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Riku Voipio <address@hidden>
---
linux-user/syscall.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 7f12563..e0c71fb 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -7694,18 +7694,20 @@ abi_long do_syscall(void *cpu_env, int num, abi_long
arg1,
{
int gidsetsize = arg1;
target_id *target_grouplist;
- gid_t *grouplist;
+ gid_t *grouplist = NULL;
int i;
-
- grouplist = alloca(gidsetsize * sizeof(gid_t));
- target_grouplist = lock_user(VERIFY_READ, arg2, gidsetsize * 2, 1);
- if (!target_grouplist) {
- ret = -TARGET_EFAULT;
- goto fail;
+ if (gidsetsize) {
+ grouplist = alloca(gidsetsize * sizeof(gid_t));
+ target_grouplist = lock_user(VERIFY_READ, arg2, gidsetsize *
2, 1);
+ if (!target_grouplist) {
+ ret = -TARGET_EFAULT;
+ goto fail;
+ }
+ for (i = 0; i < gidsetsize; i++) {
+ grouplist[i] = low2highgid(tswapid(target_grouplist[i]));
+ }
+ unlock_user(target_grouplist, arg2, 0);
}
- for(i = 0;i < gidsetsize; i++)
- grouplist[i] = low2highgid(tswapid(target_grouplist[i]));
- unlock_user(target_grouplist, arg2, 0);
ret = get_errno(setgroups(gidsetsize, grouplist));
}
break;
--
1.8.1.2
- [Qemu-devel] [PATCH 0/7] linux-user updates, riku . voipio, 2013/03/07
- [Qemu-devel] [PATCH 1/7] linux-user: Add Alpha socket constants, riku . voipio, 2013/03/07
- [Qemu-devel] [PATCH 2/7] linux-user: improve print_fcntl(), riku . voipio, 2013/03/07
- [Qemu-devel] [PATCH 3/7] linux-user/syscall.c: handle FUTEX_WAIT_BITSET in do_futex, riku . voipio, 2013/03/07
- [Qemu-devel] [PATCH 4/7] linux-user: fix futex strace of FUTEX_CLOCK_REALTIME, riku . voipio, 2013/03/07
- [Qemu-devel] [PATCH 6/7] linux-user: Support setgroups syscall with no groups,
riku . voipio <=
- [Qemu-devel] [PATCH 5/7] linux-user: correct semctl() and shmctl(), riku . voipio, 2013/03/07
- [Qemu-devel] [PATCH 7/7] linux-user: Add more sparc syscall numbers, riku . voipio, 2013/03/07
- Re: [Qemu-devel] [PATCH 0/7] linux-user updates, Peter Maydell, 2013/03/07
- Re: [Qemu-devel] [PATCH 0/7] linux-user updates, Peter Maydell, 2013/03/09