Re: [Qemu-devel] [PATCH V8 02/20] build: add block/qapi.c

[Wenchao Xia]

于 2013-3-9 4:22, Eric Blake 写道:
> On 03/06/2013 11:07 PM, Wenchao Xia wrote:
>>    This file will have qmp related functions for block. To avoid conflict and
>> tip better, macro in header file is BLOCK_QAPI_H instead of QAPI_H.
>>
>> Signed-off-by: Wenchao Xia <address@hidden>
>> ---
> 
>> --- /dev/null
>> +++ b/include/block/qapi.h
>> @@ -0,0 +1,4 @@
>> +#ifndef BLOCK_QAPI_H
> 
> Again, introducing a new file without a copyright notice is a no-no.
> 
> Why are you adding stub files in two separate patches?  If you're going
> to bother with stub files, then add all of them in one commit.  But my
> preference would be to add one file at a time, but with contents instead
> of being a stub (for example, merge patch 1 and 3, and merge patch 2 and
> 6).  It just feels like you have subdivided this series too far.
> 
  Just to make it easy for review, one patch for one step. I am OK to
merge if you insist, but prefer not for that these stub brings no
trouble, to save effort.



-- 
Best Regards

Wenchao Xia