Re: [Qemu-devel] [PATCH v2 5/5] net: make netclient re-entrant with refcnt

[Paolo Bonzini]

Il 07/03/2013 03:53, Liu Ping Fan ha scritto:
> From: Liu Ping Fan <address@hidden>
> 
> With refcnt, NetClientState's caller can run agaist reclaimer.
> 
> Signed-off-by: Liu Ping Fan <address@hidden>
> ---
>  hw/qdev-properties-system.c |   14 +++++++++++++
>  include/net/net.h           |    3 ++
>  net/hub.c                   |    3 ++
>  net/net.c                   |   46 ++++++++++++++++++++++++++++++++++++++++--
>  net/slirp.c                 |    3 +-
>  5 files changed, 65 insertions(+), 4 deletions(-)

The patch makes sense, but the commit message does not yet.

Please add documentation to include/net/net.h, specifying the functions
that add a reference to the returned NetClientState.

Paolo