[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapsh
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info |
Date: |
Tue, 12 Mar 2013 11:07:54 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Mar 11, 2013 at 07:23:02PM +0800, Wenchao Xia wrote:
> In the use of snapshot a way to retrieve related info at runtime is needed,
> so this serial of patches will merge some code for qemu and qemu-img, and add
> following interfaces for qemu:
>
> 1) qmp: query-images, show image info for a block device
> Example:
> -> { "execute": "query-images" }
> <- {
> "return":[
> {
> "device":"ide0-hd0",
> "image":{
> "filename":"disks/test1.img",
> "format":"qcow2",
> "virtual-size":2048000,
> "snapshots":[
> {
> "id": "1",
> "name": "snapshot1",
> "vm-state-size": 0,
> "date-sec": 10000200,
> "date-nsec": 12,
> "vm-clock-sec": 206,
> "vm-clock-nsec": 30
> }
> ]
> }
> }
> ]
> }
See my recent RFC patch to add a virtual_size to query-block:
http://permalink.gmane.org/gmane.comp.emulators.qemu/199443
Is there a reason you added the new query-images command instead of
extending BlockDeviceInfo with an ImageInfo field? Then query-block,
which is already used today, just provides ImageInfo as well.
I suggest this because it makes life easier for clients - they can issue
a single command to extract all image information. If we have two
commands they may have to invoke both and then match the results
together.
Stefan
- Re: [Qemu-devel] [PATCH V9 09/14] qmp: add interface query-images, (continued)
- [Qemu-devel] [PATCH V9 07/14] block: add image info query function bdrv_query_image_info(), Wenchao Xia, 2013/03/11
- [Qemu-devel] [PATCH V9 10/14] hmp: add function hmp_info_snapshots(), Wenchao Xia, 2013/03/11
- [Qemu-devel] [PATCH V9 08/14] qmp: add interface query-snapshots, Wenchao Xia, 2013/03/11
- [Qemu-devel] [PATCH V9 11/14] hmp: switch snapshot info function to qmp based one, Wenchao Xia, 2013/03/11
- [Qemu-devel] [PATCH V9 12/14] block: move dump_human_image_info() to block/qapi.c, Wenchao Xia, 2013/03/11
- [Qemu-devel] [PATCH V9 14/14] hmp: add command info images, Wenchao Xia, 2013/03/11
- [Qemu-devel] [PATCH V9 13/14] block: dump to buffer for bdrv_image_info_dump(), Wenchao Xia, 2013/03/11
- Re: [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info,
Stefan Hajnoczi <=
- Re: [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info, Eric Blake, 2013/03/12
- Re: [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info, Wenchao Xia, 2013/03/12
- Re: [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info, Stefan Hajnoczi, 2013/03/13
- Re: [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info, Eric Blake, 2013/03/13
- Re: [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info, Kevin Wolf, 2013/03/13
- Re: [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info, Stefan Hajnoczi, 2013/03/13
- Re: [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info, Wenchao Xia, 2013/03/15
- Re: [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info, Kevin Wolf, 2013/03/15
- Re: [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info, Wenchao Xia, 2013/03/18
- Re: [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info, Kevin Wolf, 2013/03/18