Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

[Eric Blake]

On 03/11/2013 11:01 PM, Wenchao Xia wrote:
> 于 2013-3-12 1:49, Eric Blake 写道:
>> On 03/11/2013 05:23 AM, Wenchao Xia wrote:
>>>    This patch adds block/snapshot.c and then moves the function
>>> there. It also fixes small code style errors reported by check script.
>>>

>>> + * This work is licensed under the terms of the GNU LGPL, version 2
>>> or later.
>>
>> Furthermore, the code you are moving was under BSD license, so by moving
>> the code, you have changed its license to something more restrictive.
>> Personally, I like LGPL better than BSD, but as I'm not the copyright
>> holder of the original code, and neither are you, I'm not sure that
>> either of us is qualified to make that change.  Therefore, I'm unwilling
>> to add my Reviewed-by, even though the code motion itself is correct,
>> without a maintainer chiming in on whether your licensing is appropriate
>> or needs an adjustment.
>>
>   Oops, Since it belongs to block layer I hope it can be LGPL2. Do you
> know how to contact Fabrice Bellard to ask for a change?

As far as I can tell, there is nothing wrong with leaving the file as
BSD licensed instead of trying to insist that it be LGPL.  The block
layer will still be [L]GPL because of other files linked together, but
there is nothing inherently wrong with linking a BSD file into an [L]GPL
product.  In other words, if you are okay with keeping the existing
looser BSD license on this file only, it still won't change the license
of the overall block layer, and it would save you the hassle of tracking
down earlier authors to ask for a relicense.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature