[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 7/7] pcie: Mangle types to match topology
From: |
Alex Williamson |
Subject: |
[Qemu-devel] [PATCH 7/7] pcie: Mangle types to match topology |
Date: |
Thu, 14 Mar 2013 16:01:35 -0600 |
User-agent: |
StGit/0.16 |
Windows will fail to start drivers for devices with an Endpoint type
PCIe capability attached to a Root Complex (code 10 - Device cannot
start). The proper type for such a device is Root Complex Integrated
Endpoint. Devices don't care which they are, so do this conversion
automatically.
This allows the Windows driver to load for nec-usb-xhci when attached
to pcie.0 of a q35 machine.
Signed-off-by: Alex Williamson <address@hidden>
---
hw/pci/pcie.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 485c94c..bcfbae4 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -48,6 +48,19 @@ int pcie_cap_init(PCIDevice *dev, uint8_t offset, uint8_t
type, uint8_t port)
assert(pci_is_express(dev));
+ /*
+ * Mangle type to convert Endpoints to Root Complex Integrated Endpoints.
+ * Windows will report Code 10 (device cannot start) for regular Endpoints
+ * on the Root Complex.
+ */
+ if (pci_bus_is_express(dev->bus) && pci_bus_is_root(dev->bus)) {
+ switch (type) {
+ case PCI_EXP_TYPE_ENDPOINT:
+ type = PCI_EXP_TYPE_RC_END;
+ break;
+ }
+ }
+
pos = pci_add_capability(dev, PCI_CAP_ID_EXP, offset,
PCI_EXP_VER2_SIZEOF);
if (pos < 0) {
- [Qemu-devel] [PATCH 0/7] pci: Create PCI Express bus type, Alex Williamson, 2013/03/14
- [Qemu-devel] [PATCH 1/7] pci: Create and register a new PCI Express TypeInfo, Alex Williamson, 2013/03/14
- [Qemu-devel] [PATCH 2/7] pci: Move PCI and PCIE type defines, Alex Williamson, 2013/03/14
- [Qemu-devel] [PATCH 3/7] pci: Allow PCI bus creation interfaces to specify the type of bus, Alex Williamson, 2013/03/14
- [Qemu-devel] [PATCH 5/7] pci: Create pci_bus_is_express helper, Alex Williamson, 2013/03/14
- [Qemu-devel] [PATCH 4/7] pci: Q35, Root Ports, and Switches create PCI Express buses, Alex Williamson, 2013/03/14
- [Qemu-devel] [PATCH 6/7] pci: Create and use API to determine root buses, Alex Williamson, 2013/03/14
- [Qemu-devel] [PATCH 7/7] pcie: Mangle types to match topology,
Alex Williamson <=
- Re: [Qemu-devel] [PATCH 0/7] pci: Create PCI Express bus type, Michael S. Tsirkin, 2013/03/17