[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] configure: fix coroutine backend selecti
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] configure: fix coroutine backend selection logic |
Date: |
Fri, 15 Mar 2013 09:09:19 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 |
Il 14/03/2013 18:57, Peter Maydell ha scritto:
> The main aim of this patchset is patch 2, which changes the coroutine
> backend selection logic so that it goes 'ucontext -> sigaltstack'
> rather than 'ucontext -> gthread', since the gthread backend is
> broken. To do this properly on all platforms we have to refactor
> the code a bit (which it needed anyway).
>
> The first patch here is a generic configure cleanup to how we print
> error messages, which I wanted for the third patch because otherwise
> the various error paths would have been rather verbose.
>
> Changes v1->v2:
> * fix the tests makefile too
> * CONFIG_COROUTINE_BACKEND=foo rather than CONFIG_FOO_COROUTINE=y;
> this simplifies both the configure code and the makefiles
> * dropped the 'move upper()' patch as no longer needed (in this
> series, anyway)
>
> Peter Maydell (2):
> configure: Provide and use convenience error reporting function
> configure: Don't fall back to gthread coroutine backend
>
> Makefile.objs | 11 +--
> configure | 257
> ++++++++++++++++++++++++++------------------------------
> tests/Makefile | 14 +--
> 3 files changed, 119 insertions(+), 163 deletions(-)
>
Reviewed-by: Paolo Bonzini <address@hidden>