[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] Fix VMSTATE_BUFFER_UNSAFE macro usage
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH 0/3] Fix VMSTATE_BUFFER_UNSAFE macro usage |
|
Date: |
Mon, 18 Mar 2013 16:19:02 +0000 |
On 10 March 2013 13:47, Igor Mitsyanko <address@hidden> wrote:
> hw/sd.c and hw/onenand.c were wrongly using VMSTATE_BUFFER_UNSAFE for
> dynamically
> allocated buffer migration, this was causing memory corruption.
> Use VMSTATE_BUFFER_POINTER_UNSAFE (wich has an additional VMS_POINTER flag
> set) instead.
>
> Not sure what to do with vmstate version for his devices, should I bump it?
> Migration
> was never working for them anyway.
>
> Only tested hw/sd.c, by saving/loading a snapshot of VM while it was playing
> videofile
> from SD card.
>
> Igor Mitsyanko (3):
> vmstate.h: introduce VMSTATE_BUFFER_POINTER_UNSAFE macro
> hw/sd.c: fix migration of dynamically allocated buffer "buf"
> hw/onenand.c: fix migration of dynamically allocated buffer "otp"
Whole series:
Reviewed-by: Peter Maydell <address@hidden>
-- PMM